Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SST: Add MPI SST dataplane #3095

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Mar 8, 2022

This PR adds a new MPI Data Plane for the SST engine.

  • It adds a SST DataPlane named MPI_DP
  • It modifies SST tests MPI_Init to use MPI_MULTIPLE_THREAD
  • It adds a new MPICH build based on AlmaLinux 8.
  • It includes workarounds in the tests for the MPI_DP to work in Cray-MPICH implementations.
  • It adds a new document detailing how to run this new DataPlane in ECP supercomputers.
  • Minor fix in the selection of SST Data plane.

@vicentebolea vicentebolea force-pushed the add-mpi-dataplane branch 4 times, most recently from 51a1c49 to 62490b7 Compare March 10, 2022 01:10
@vicentebolea
Copy link
Collaborator Author

@chuckatkins there has been substantial progress in this task 🎉 . This new DP using MPI is working (sending/receiving) for simple tasks and some tests work. I will secure that we can pass all the test with this and then I will move to further optimizing this.

@vicentebolea vicentebolea changed the title [DONT MERGE] SST: Add MPI SST dataplane SST: Add MPI SST dataplane Mar 15, 2022
@vicentebolea vicentebolea force-pushed the add-mpi-dataplane branch 4 times, most recently from 1deeb7b to f55aa57 Compare March 21, 2022 22:35
CMakeLists.txt Outdated Show resolved Hide resolved
@vicentebolea vicentebolea self-assigned this Mar 22, 2022
@vicentebolea vicentebolea force-pushed the add-mpi-dataplane branch 8 times, most recently from dd4c43e to 34b9d3a Compare March 29, 2022 00:08
@vicentebolea vicentebolea force-pushed the add-mpi-dataplane branch 4 times, most recently from 22156e8 to 2fc2422 Compare March 30, 2022 15:50
@vicentebolea vicentebolea force-pushed the add-mpi-dataplane branch 3 times, most recently from 568ba8e to 84f0a44 Compare May 31, 2022 00:44
@vicentebolea vicentebolea force-pushed the add-mpi-dataplane branch 6 times, most recently from 8e5c19a to 02c71d6 Compare June 10, 2022 01:49
@vicentebolea
Copy link
Collaborator Author

@chuckatkins we have a new MPICH build and its green :) https://github.com/ornladios/ADIOS2/runs/6823739729?check_suite_focus=true

@vicentebolea vicentebolea force-pushed the add-mpi-dataplane branch 4 times, most recently from 860f312 to 95c3627 Compare June 10, 2022 21:08
@vicentebolea vicentebolea marked this pull request as ready for review July 5, 2022 23:39
@vicentebolea vicentebolea requested review from chuckatkins, eisenhauer and JasonRuonanWang and removed request for JasonRuonanWang July 6, 2022 01:22
@vicentebolea
Copy link
Collaborator Author

@suchyta1

@pnorbert pnorbert self-requested a review July 20, 2022 19:11
Copy link
Contributor

@pnorbert pnorbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short comment for MPI_Init_thread() calls in the examples that it is only needed for SST/MPI-data plane

@pnorbert pnorbert merged commit ee3bfc8 into ornladios:master Jul 20, 2022
@vicentebolea vicentebolea deleted the add-mpi-dataplane branch July 20, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants